| From: | Abhijit Menon-Sen <ams(at)2ndQuadrant(dot)com> |
|---|---|
| To: | Andres Freund <andres(at)2ndquadrant(dot)com> |
| Cc: | Heikki Linnakangas <hlinnakangas(at)vmware(dot)com>, Dilip kumar <dilip(dot)kumar(at)huawei(dot)com>, pgsql-hackers(at)postgresql(dot)org, furuyao(at)pm(dot)nttdata(dot)co(dot)jp |
| Subject: | Re: pg_xlogdump --stats |
| Date: | 2014-09-19 10:09:37 |
| Message-ID: | 20140919100937.GA24243@toroid.org |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
I've attached the revised patch, split up differently:
1. Introduce rm_identify, change rm_desc, glue the two together in
xlog.c
2. Introduce pg_xlogdump --stats[=record].
The requested changes (16, filter, z:, UNKNOWN) are included. The
grammar nitpicking and rebase cruft is^Ware^Wain't included.
I ran Postgres with WAL_DEBUG for a while, and I ran pg_xlogdump with
--stats (and --stats=rmgr) and --stats=record with and without a few
different variants of "-r heap". Everything looked OK to me.
I hope I didn't miss anything this time.
-- Abhijit
| Attachment | Content-Type | Size |
|---|---|---|
| 0001-Introduce-an-RmgrDescData.rm_identify-callback-to-na.patch | text/x-diff | 55.3 KB |
| 0002-Make-pg_xlogdump-stats-record-display-summary-statis.patch | text/x-diff | 12.1 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Abhijit Menon-Sen | 2014-09-19 10:14:24 | Re: pg_xlogdump --stats |
| Previous Message | Andres Freund | 2014-09-19 10:00:16 | GCC memory barriers are missing "cc" clobbers |