Re: [TODO] Process pg_hba.conf keywords as case-insensitive

From: Kyotaro HORIGUCHI <horiguchi(dot)kyotaro(at)lab(dot)ntt(dot)co(dot)jp>
To: robertmhaas(at)gmail(dot)com
Cc: cb(at)df7cb(dot)de, viswanatham(dot)kirankumar(at)huawei(dot)com, hlinnakangas(at)vmware(dot)com, tgl(at)sss(dot)pgh(dot)pa(dot)us, pgsql-hackers(at)postgresql(dot)org
Subject: Re: [TODO] Process pg_hba.conf keywords as case-insensitive
Date: 2014-09-17 09:13:54
Message-ID: 20140917.181354.230997917.horiguchi.kyotaro@lab.ntt.co.jp
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi,

At Thu, 11 Sep 2014 08:10:54 -0400, Robert Haas <robertmhaas(at)gmail(dot)com> wrote in <CA+TgmoZ9xiNc_cA23-p1dMiHMV0zHcKeF6_rV6V3S+OxRLACNg(at)mail(dot)gmail(dot)com>
> On Wed, Sep 10, 2014 at 4:54 AM, Kyotaro HORIGUCHI
> <horiguchi(dot)kyotaro(at)lab(dot)ntt(dot)co(dot)jp> wrote:
> > Finally I think that we need case-insensitive version of
> > get_role_id and() get_database_id() to acoomplish this patch'es
> > objective. (This runs full-scans on pg_database or pg_authid X()
>
> Any such thing is certainly grounds for rejecting the patch outright.
> It may be that pg_hba.conf should follow the same case-folding rules
> we use elsewhere, but it should not invent novel semantics, especially
> ones that make connecting to the database a far more expensive
> operation than it is today.

No wonder. I wondered why such things are needed for this
'case-insensitive matcing'. I've misunderstood the meaning of
'case-insensitive'. There's no need to scanning catalogues for
the 'case-insensitive' matching. Thank you for suggestion.

- Non-quoted names are matched with the names in the catalog
after lowercased.

- Quoted names are matched as is.

This is archieved by simply downcase the identifier if not
case-insensitive notation, and remove case-insensitive version
catalog stuff.

I'll show you more reasonable version sooner.

--
Kyotaro Horiguchi
NTT Open Source Software Center

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Kyotaro HORIGUCHI 2014-09-17 09:15:43 Re: Escaping from blocked send() reprised.
Previous Message Alexander Korotkov 2014-09-17 09:04:16 Re: KNN-GiST with recheck