From: | Abhijit Menon-Sen <ams(at)2ndQuadrant(dot)com> |
---|---|
To: | Heikki Linnakangas <hlinnakangas(at)vmware(dot)com> |
Cc: | Andres Freund <andres(at)2ndquadrant(dot)com>, Dilip kumar <dilip(dot)kumar(at)huawei(dot)com>, pgsql-hackers(at)postgresql(dot)org, furuyao(at)pm(dot)nttdata(dot)co(dot)jp |
Subject: | Re: pg_xlogdump --stats |
Date: | 2014-09-11 08:43:16 |
Message-ID: | 20140911084316.GA20687@toroid.org |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
At 2014-08-21 10:06:39 +0300, hlinnakangas(at)vmware(dot)com wrote:
>
> Committed the patch to add INT64_MODIFIER, with minor fixes.
Thank you.
> The new rm_identify method needs to be documented. […]
> Perhaps add comments to the RmgrData struct, explaining
> all of the methods.
OK, I'll submit a patch to add these comments.
> I think the names that rm_identify returns should match those that the
> rm_desc functions print.
I had originally started off trying to keep the output in sync, but it
doesn't work very well. There are rm_desc functions that print things
like "truncate before" and "Create posting tree", and many decisions
are quite arbitrary ("freeze_page", "cleanup info", "multi-insert").
I think it's better the (grep-friendly) way it is. If anything, perhaps
rm_desc should output "${rm_identify}[: optional explanation]". That
would also make it very clear what should go in rm_identify and what
should go in rm_desc.
Thoughts?
> The corresponding rm_identify output is:
>
> HOT_UPDATE+INIT
The +INIT is admittedly a special case, and I would have no objection to
writing that as (INIT) or something instead.
-- Abhijit
From | Date | Subject | |
---|---|---|---|
Next Message | Heikki Linnakangas | 2014-09-11 09:14:42 | Re: pg_xlogdump --stats |
Previous Message | Amit Kapila | 2014-09-11 08:01:15 | Re: Support for N synchronous standby servers |