Re: Spinlocks and compiler/memory barriers

From: Andres Freund <andres(at)2ndquadrant(dot)com>
To: Robert Haas <robertmhaas(at)gmail(dot)com>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Spinlocks and compiler/memory barriers
Date: 2014-09-08 23:10:44
Message-ID: 20140908231044.GA21619@awork2.anarazel.de
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 2014-09-04 08:18:37 -0400, Robert Haas wrote:
> On Tue, Aug 5, 2014 at 11:55 AM, Robert Haas <robertmhaas(at)gmail(dot)com> wrote:
> > On Sun, Jul 6, 2014 at 3:12 PM, Andres Freund <andres(at)2ndquadrant(dot)com> wrote:
> >>> > If you want to do that, it's fine with me. What I would do is:
> >>> >
> >>> > - Back-patch the addition of the sparcv8+ stuff all the way. If
> >>> > anyone's running anything older, let them complain...
> >>> > - Remove the special case for MIPS without gcc intrinsics only in
> >>> > master, leaving the back-branches broken. If anyone cares, let them
> >>> > complain...
> >>> > - Nothing else.
> >>>
> >>> I've gone ahead and done the second of these things.
> >>
> >> Thanks.
> >>
> >>> Andres, do you want to go take a stab at fixing the SPARC stuff?
> >>
> >> Will do, will probably take me till thursday to come up with the brain
> >> cycles.
> >
> > Ping?
>
> This has been pending for almost two months now and, at your request,
> my patch to make spinlocks act as compiler barriers is waiting behind
> it. Can we please get this moving again soon, or can I commit that
> patch and you can fix this when you get around to it?

I finally pushed this. And once more I seriously got pissed at the poor
overall worldwide state of documentation and continously changing
terminology around this.

Sorry for taking this long :(

Do you have a current version of your patch to make them compiler
barriers?

Andres Freund

--
Andres Freund http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Amit Kapila 2014-09-09 03:48:56 Re: Scaling shared buffer eviction
Previous Message David G Johnston 2014-09-08 22:24:58 Re: PQputCopyEnd doesn't adhere to its API contract