Re: pg_upgrade: allow multiple -o/-O options

From: Bruce Momjian <bruce(at)momjian(dot)us>
To: Pavel Raiskup <praiskup(at)redhat(dot)com>
Cc: pgsql-hackers(at)postgresql(dot)org, hhorak(at)redhat(dot)com
Subject: Re: pg_upgrade: allow multiple -o/-O options
Date: 2014-08-21 22:26:37
Message-ID: 20140821222637.GC17771@momjian.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Tue, Mar 4, 2014 at 04:52:56PM +0100, Pavel Raiskup wrote:
> Hello,
>
> RFE: Consider that you want to run pg_upgrade via some script with some
> default '-o' option. But then you also want to give the script's user a
> chance to specify the old-server's options according user's needs.
> Then something like the following is not possible:
>
> $ cat script
> ...
> pg_upgrade ... -o 'sth' $PG_UPGRADE_OPT ...
> ...
>
> I know that this problem is still script-able, but the fix should be
> innocent and it would simplify things. Thanks for considering,

Attached is a patch that makes multiple -o options append their
arguments for pg_upgrade and pg_ctl, and documents this and the append
behavior of postmaster/postgres. This covers all the -o behaviors.

--
Bruce Momjian <bruce(at)momjian(dot)us> http://momjian.us
EnterpriseDB http://enterprisedb.com

+ Everyone has their own god. +

Attachment Content-Type Size
dash-o.diff text/x-diff 5.9 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Alvaro Herrera 2014-08-21 23:04:36 Re: [GSoC2014] Patch ALTER TABLE ... SET LOGGED
Previous Message Stephen Frost 2014-08-21 22:15:33 Re: WIP Patch for GROUPING SETS phase 1