Re: [REVIEW] pg_last_xact_insert_timestamp

Hi,

On 2011-10-04 20:52:59 +0900, Fujii Masao wrote:
> *** a/src/backend/access/transam/xact.c
> --- b/src/backend/access/transam/xact.c
> ***************
> *** 1066,1071 **** RecordTransactionCommit(void)
> --- 1066,1074 ----
>
> (void) XLogInsert(RM_XACT_ID, XLOG_XACT_COMMIT_COMPACT, rdata);
> }
> +
> + /* Save timestamp of latest transaction commit record */
> + pgstat_report_xact_end_timestamp(xactStopTimestamp);
> }
>

Perhaps that pgstat_report() should instead be combined with the
pgstat_report_xact_timestamp(0) in CommitTransaction()? Then the number
of changecount increases and cacheline references would stay the
same. The only thing that'd change would be a single additional
assignment.

Greetings,

Andres Freund

--
Andres Freund http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services