| From: | Noah Misch <noah(at)leadboat(dot)com> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | pgsql-hackers(at)postgreSQL(dot)org, Peter Eisentraut <peter_e(at)gmx(dot)net> |
| Subject: | Re: [COMMITTERS] pgsql: Diagnose incompatible OpenLDAP versions during build and test. |
| Date: | 2014-07-24 00:37:01 |
| Message-ID: | 20140724003701.GA2471970@tornado.leadboat.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers pgsql-hackers |
On Tue, Jul 22, 2014 at 11:51:18AM -0400, Tom Lane wrote:
> Noah Misch <noah(at)leadboat(dot)com> writes:
> > Diagnose incompatible OpenLDAP versions during build and test.
>
> Hmm. I'm pretty sure it is not considered good style to drop AC_DEFUN
> blocks right into configure.in; at least, we have never done that before.
> PGAC_LDAP_SAFE should get defined somewhere in config/*.m4, instead.
> I am not real sure however which existing config/ file is appropriate,
> or whether we should create a new one. Peter, any opinion?
I don't mind reinstating the absence of AC_DEFUN from configure.in. Add
config/misc-libraries.m4, perhaps? Alternately, stretch programs.m4; it
already has two readline library checks.
--
Noah Misch
EnterpriseDB http://www.enterprisedb.com
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2014-07-24 00:45:44 | Re: [COMMITTERS] pgsql: Diagnose incompatible OpenLDAP versions during build and test. |
| Previous Message | pgsql | 2014-07-23 19:27:54 | pgsql: Tag refs/tags/REL9_1_14 was created |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2014-07-24 00:45:44 | Re: [COMMITTERS] pgsql: Diagnose incompatible OpenLDAP versions during build and test. |
| Previous Message | Thomas Munro | 2014-07-23 23:52:22 | Re: SKIP LOCKED DATA (work in progress) |