| From: | Andres Freund <andres(at)2ndquadrant(dot)com> |
|---|---|
| To: | Fabrízio de Royes Mello <fabriziomello(at)gmail(dot)com> |
| Cc: | Christoph Berg <cb(at)df7cb(dot)de>, Pgsql Hackers <pgsql-hackers(at)postgresql(dot)org>, Stephen Frost <sfrost(at)snowman(dot)net> |
| Subject: | Re: [GSoC2014] Patch ALTER TABLE ... SET LOGGED |
| Date: | 2014-07-16 18:53:06 |
| Message-ID: | 20140716185306.GB12629@alap3.anarazel.de |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 2014-07-16 20:25:42 +0200, Andres Freund wrote:
> Hi,
>
> I quickly looked at this patch and I think there's major missing pieces
> around buffer management and wal logging.
>
> a) Currently buffers that are in memory marked as
> permanent/non-permanent aren't forced out to disk/pruned from cache,
> not even when they're dirty.
> b) When converting from a unlogged to a logged table the relation needs
> to be fsynced.
> c) Currently a unlogged table changed into a logged one will be
> corrupted on a standby because its contents won't ever be WAL logged.
Forget that, didn't notice that you're setting tab->rewrite = true.
Greetings,
Andres Freund
--
Andres Freund http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Pavel Stehule | 2014-07-16 19:35:29 | Re: Built-in binning functions |
| Previous Message | Andres Freund | 2014-07-16 18:25:42 | Re: [GSoC2014] Patch ALTER TABLE ... SET LOGGED |