| From: | Noah Misch <noah(at)leadboat(dot)com> |
|---|---|
| To: | Michael Paquier <michael(dot)paquier(at)gmail(dot)com> |
| Cc: | MauMau <maumau307(at)gmail(dot)com>, Magnus Hagander <magnus(at)hagander(dot)net>, pgsql-bugs <pgsql-bugs(at)postgresql(dot)org> |
| Subject: | Re: Missing file versions for a bunch of dll/exe files in Windows builds |
| Date: | 2014-07-14 19:03:28 |
| Message-ID: | 20140714190328.GB2088773@tornado.leadboat.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-bugs |
On Fri, Jul 11, 2014 at 11:14:54PM -0700, Michael Paquier wrote:
> On Fri, Jul 11, 2014 at 10:34 PM, Noah Misch <noah(at)leadboat(dot)com> wrote:
> > Please fix the MODULES case, perhaps by linking $(WIN32RES) into each library
> > implicitly.
> Yes, that's exactly what I did in the patch attached by linking
> WIN32RES and a shared library when the lib is built from a single .o
> file. The rule in src/makefiles/Makefile.win32 has been updated
> accordingly. pgxs.mk has been updated as well to remove WIN32RES when
> clean is invoked for MODULES.
There remained several binaries versioned under MSVC and not versioned under
MinGW. With those fixed, I committed this work.
--
Noah Misch
EnterpriseDB http://www.enterprisedb.com
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2014-07-14 23:04:59 | Re: Missing file versions for a bunch of dll/exe files in Windows builds |
| Previous Message | David Tonhofer | 2014-07-14 18:50:38 | Documentation problem: The syntax for "\copy" is just wrong |