Re: Audit of logout

From: Abhijit Menon-Sen <ams(at)2ndQuadrant(dot)com>
To: Joe Conway <mail(at)joeconway(dot)com>
Cc: Fujii Masao <masao(dot)fujii(at)gmail(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: Audit of logout
Date: 2014-07-02 20:20:21
Message-ID: 20140702202021.GB10574@toroid.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

At 2014-07-02 12:52:51 -0700, mail(at)joeconway(dot)com wrote:
>
> Doesn't mean that to me but feel free to change it to Waiting on
> Author if you prefer :-)
>
> Is there any official explanation as to what those states mean
> documented anywhere?

I don't know if there's an official definition, but my understanding of
"returned with feedback" was always pretty much in agreement with what
Fujii wrote. If the author is expected to post a revised patch soon, it
gets marked "waiting on author", and "returned with feedback" means it
will take longer, probably in the next CF.

But I also treat these labels as a matter of convenience, and definitely
not some mark of shame where the author should feel upset that the patch
was put in one state or the other. As far as I'm concerned, patches can
be switched from "returned with feedback" to "needs review" to "ready
for committer" at the drop of a hat if updates are made in time.

-- Abhijit

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Kevin Grittner 2014-07-02 20:35:16 Re: Re: Patch to send transaction commit/rollback stats to the stats collector unconditionally.
Previous Message Tom Lane 2014-07-02 20:17:13 Re: Can simplify 'limit 1' with slow function?