From: | Andres Freund <andres(at)2ndquadrant(dot)com> |
---|---|
To: | Thomas Munro <munro(at)ip9(dot)org> |
Cc: | Fujii Masao <masao(dot)fujii(at)gmail(dot)com>, Abhijit Menon-Sen <ams(at)2ndquadrant(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Stephen Frost <sfrost(at)snowman(dot)net>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: Cluster name in ps output |
Date: | 2014-06-29 09:55:11 |
Message-ID: | 20140629095511.GJ6450@awork2.anarazel.de |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Hi,
On 2014-06-28 15:08:45 +0200, Andres Freund wrote:
> Otherwise it looks good to me.
So, I'd looked at it with an eye towards committing it and found some
more things. I've now
* added the restriction that the cluster name can only be ASCII. It's
shown from several clusters with differing encodings, and it's shown
in process titles, so that seems wise.
* moved everything to the LOGGING_WHAT category
* added minimal documention to monitoring.sgml
* expanded the config.sgml entry to mention the restriction on the name.
* Changed the GUCs short description
I'll leave the patch sit a while before actually committing it.
I also think, but haven't done so, we should add a double colon after
the cluster name, so it's not:
postgres: server1 stats collector process
but
postgres: server1: stats collector process
Comments?
Greetings,
Andres Freund
--
Andres Freund http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services
Attachment | Content-Type | Size |
---|---|---|
0001-Add-cluster_name-GUC-which-will-be-included-in-proce.patch | text/x-patch | 7.3 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Thomas Munro | 2014-06-29 10:11:14 | Re: Cluster name in ps output |
Previous Message | Andres Freund | 2014-06-29 09:31:30 | Re: better atomics - v0.5 |