| From: | Bruce Momjian <bruce(at)momjian(dot)us> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Stephen Frost <sfrost(at)snowman(dot)net>, Robert Haas <robertmhaas(at)gmail(dot)com>, Andrew Dunstan <andrew(at)dunslane(dot)net>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: pg_control is missing a field for LOBLKSIZE |
| Date: | 2014-06-18 00:46:00 |
| Message-ID: | 20140618004600.GH3666@momjian.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, Jun 17, 2014 at 07:12:16PM -0400, Tom Lane wrote:
> Bruce Momjian <bruce(at)momjian(dot)us> writes:
> > On Tue, Jun 17, 2014 at 03:55:02PM -0400, Alvaro Herrera wrote:
> >> Can't you compare it to the historic default value? I mean, add an
> >> assumption that people thus far has never tweaked it.
>
> > Well, if they did tweak it, then they would be unable to use pg_upgrade
> > because it would complain about a mismatch if they actually matched the
> > old and new servers.
>
> What about comparing to the symbolic value LOBLKSIZE? This would make
> pg_upgrade assume that the old installation had been tweaked the same
> as in its own build. This ends up being the same as what you said,
> ie, effectively no comparison ... but it might be less complicated to
> code/understand.
OK, assume the compiled-in default is the value for an old cluster that
has no value --- yeah, I could do that.
--
Bruce Momjian <bruce(at)momjian(dot)us> http://momjian.us
EnterpriseDB http://enterprisedb.com
+ Everyone has their own god. +
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Peter Geoghegan | 2014-06-18 00:57:23 | Re: btreecheck extension |
| Previous Message | Andreas Karlsson | 2014-06-18 00:39:44 | Re: Re: [REVIEW] psql tab completion for DROP TRIGGER/RULE and ALTER TABLE ... DISABLE/ENABLE |