Re: Add CREATE support to event triggers

From: Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>
To: Jim Nasby <jim(at)nasby(dot)net>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Robert Haas <robertmhaas(at)gmail(dot)com>, Dimitri Fontaine <dimitri(at)2ndquadrant(dot)fr>, Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Add CREATE support to event triggers
Date: 2014-06-15 04:17:12
Message-ID: 20140615041711.GZ18688@eldon.alvh.no-ip.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Jim Nasby wrote:
> On 2/6/14, 11:20 AM, Alvaro Herrera wrote:
> >NOTICE: JSON blob: {
> > "definition": [
> > {
> > "clause": "owned",
> > "fmt": "OWNED BY %{owner}D",
> > "owner": {
> > "attrname": "a",
> > "objname": "t1",
> > "schemaname": "public"
> > }
> > }
> > ],
> > "fmt": "ALTER SEQUENCE %{identity}D %{definition: }s",
> > "identity": {
> > "objname": "t1_a_seq",
> > "schemaname": "public"
> > }
> >}
> >NOTICE: expanded: ALTER SEQUENCE public.t1_a_seq OWNED BY public.t1.a
>
> Apologies if this has been discussed and I missed it, but shouldn't part of the JSON be a field that indicates what command is being run? It doesn't seem wise to conflate detecting what the command is with the overall format string.

That's reported as a separate field by the
pg_event_trigger_creation_commands function.

--
Álvaro Herrera http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Amit Kapila 2014-06-15 06:51:09 Re: Proposing pg_hibernate
Previous Message Alvaro Herrera 2014-06-15 02:34:04 Re: Minmax indexes