Re: crash with assertions and WAL_DEBUG

From: Andres Freund <andres(at)2ndquadrant(dot)com>
To: Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>
Cc: Pg Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: crash with assertions and WAL_DEBUG
Date: 2014-06-14 20:57:40
Message-ID: 20140614205740.GH6763@awork2.anarazel.de
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 2014-06-14 16:53:12 -0400, Alvaro Herrera wrote:
> Alvaro Herrera wrote:
> > I noticed that HEAD crashes at startup with assertions disabled and
> > WAL_DEBUG turned on:
>
> > I'm using an interim fix by excepting the startup process (see attached
> > patch), like the current code does for checkpointer, but I guess a more
> > robust solution should be sought.
>
> Spoke too soon. This also causes trouble when any process inserts an
> xlog record and tries to print it, of course, not just startup.

I personally think we should just remove WAL_DEBUG, but I guess I won't
convince others of that... I think for now the least bad solution is to
add a #ifndef WAL_DEBUG around that assertion.

Greetings,

Andres Freund

--
Andres Freund http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Andres Freund 2014-06-14 21:01:50 Re: crash with assertions and WAL_DEBUG
Previous Message Tom Lane 2014-06-14 20:57:33 Re: crash with assertions and WAL_DEBUG