Re: rm_desc signature

From: Abhijit Menon-Sen <ams(at)2ndquadrant(dot)com>
To: Andres Freund <andres(at)2ndquadrant(dot)com>
Cc: Heikki Linnakangas <hlinnakangas(at)vmware(dot)com>, pgsql-hackers(at)postgreSQL(dot)org
Subject: Re: rm_desc signature
Date: 2014-06-13 12:33:27
Message-ID: 20140613123327.GR5162@toroid.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

At 2014-06-13 13:39:58 +0200, andres(at)2ndquadrant(dot)com wrote:
>
> > void (*rm_desc) (StringInfo buf, uint8 xl_info, char *rec);
> > void (*rm_desc) (StringInfo buf, XLogRecord *record);
> >
> > […]
>
> +1. I've found this annoying in the past.

I like it too. I was just moving some code from pg_xlogdump into another
(new) rm_desc-like callback, and passing in the XLogRecord makes much
more sense to me.

-- Abhijit

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2014-06-13 14:04:02 Re: PL/pgSQL support to define multi variables once
Previous Message Fujii Masao 2014-06-13 12:30:32 Re: rm_desc signature