| From: | Andres Freund <andres(at)2ndquadrant(dot)com> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Heikki Linnakangas <hlinnakangas(at)vmware(dot)com>, levertond(at)googlemail(dot)com, pgsql-bugs(at)postgresql(dot)org, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> |
| Subject: | Re: BUG #10533: 9.4 beta1 assertion failure in autovacuum process |
| Date: | 2014-06-09 14:24:53 |
| Message-ID: | 20140609142453.GF3149@alap3.anarazel.de |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-bugs |
On 2014-06-09 10:21:54 -0400, Tom Lane wrote:
> Heikki Linnakangas <hlinnakangas(at)vmware(dot)com> writes:
> > On 06/09/2014 03:46 PM, Andres Freund wrote:
> >> Before I start working on a patch along those lines, do you see any
> >> problems with making the critical section smaller?
>
> > One subtle difference is that the PD_ALL_VISIBLE flag will not be
> > included in the full-page-image that log_heap_page() might take. But
> > that seems OK. visibilitymap_set() writes a WAL record that sets it at
> > replay.
>
> Huh? The visibility map call is after the page image would be taken in
> any case.
But the heap_page_is_all_visible() and PageSetAllVisible() currently
aren't. And both would have to be moved to fix the issue...
Greetings,
Andres Freund
--
Andres Freund http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andres Freund | 2014-06-09 14:33:39 | Re: BUG #10542: infinite loop in index.c when trying to reindex system tables (probably corrupted db state) |
| Previous Message | Tom Lane | 2014-06-09 14:21:54 | Re: BUG #10533: 9.4 beta1 assertion failure in autovacuum process |