Re: [BUGS] BUG #9652: inet types don't support min/max

From: Andres Freund <andres(at)2ndquadrant(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Haribabu Kommi <kommi(dot)haribabu(at)gmail(dot)com>, Keith Fiske <keith(at)omniti(dot)com>, Daniel O'Connor <darius(at)dons(dot)net(dot)au>, "pgsql-bugs(at)postgresql(dot)org" <pgsql-bugs(at)postgresql(dot)org>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [BUGS] BUG #9652: inet types don't support min/max
Date: 2014-06-03 14:27:33
Message-ID: 20140603142733.GD1220@awork2.anarazel.de
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-bugs pgsql-hackers

On 2014-06-03 10:24:46 -0400, Tom Lane wrote:
> Andres Freund <andres(at)2ndquadrant(dot)com> writes:
> > I didn't reall look at the patch, but it very much looks to me like that
> > query result could use the \a\t treatment that rules.sql and
> > sanity_check.sql got. It's hard to see the actual difference
> > before/after the patch.
> > I'll patch that now, to reduce the likelihood of changes there causing
> > conflicts for more people.
>
> Personally, I would wonder why the regression tests contain such a query
> in the first place. It seems like nothing but a major maintenance PITA.

I haven't added it, but it seems appropriate in that specific case. The
number of leakproof functions should be fairly small and every addition
should be carefully reviewed... I am e.g. not sure that it's a good idea
to declare network_smaller/greater as leakproof - but it's hard to catch
that on the basic of pg_proc.h alone.

Greetings,

Andres Freund

--
Andres Freund http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services

In response to

Responses

Browse pgsql-bugs by date

  From Date Subject
Next Message Tom Lane 2014-06-03 14:37:53 Re: [HACKERS] BUG #9652: inet types don't support min/max
Previous Message Tom Lane 2014-06-03 14:24:46 Re: [HACKERS] BUG #9652: inet types don't support min/max

Browse pgsql-hackers by date

  From Date Subject
Next Message Andres Freund 2014-06-03 14:32:31 Re: pg_basebackup failed to back up large file
Previous Message Tom Lane 2014-06-03 14:24:46 Re: [HACKERS] BUG #9652: inet types don't support min/max