Re: [PATCH] Replacement for OSSP-UUID for Linux and BSD

From: Andres Freund <andres(at)2ndquadrant(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Matteo Beccati <php(at)beccati(dot)com>, pgsql-hackers list <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [PATCH] Replacement for OSSP-UUID for Linux and BSD
Date: 2014-05-26 17:31:31
Message-ID: 20140526173131.GA11572@awork2.anarazel.de
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 2014-05-26 13:25:49 -0400, Tom Lane wrote:
> Matteo Beccati <php(at)beccati(dot)com> writes:
> > I'm attaching v2 of the patch. Here's a list of changes from v1:
>
> > * Restored --with-ossp-uuid. Configure tries ossp support first, then
> > falls back to Linux and BSD variants

Imo should be the other way round.

> > * md5.o and sha1.o are linked only when not using the ossp library

The backend already has a md5 implementation, no?

> Assuming this works as advertised, does anyone have an objection to
> pushing it into 9.4?

I think it's a pretty bad idea. But the alternatives seem worse. We
should better get it right though if we do it.

Greetings,

Andres Freund

--
Andres Freund http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Jeff Janes 2014-05-26 17:50:03 Re: Allowing line-continuation in pgbench custom scripts
Previous Message Tom Lane 2014-05-26 17:25:49 Re: [PATCH] Replacement for OSSP-UUID for Linux and BSD