Re: Patch to send transaction commit/rollback stats to the stats collector unconditionally.

From: Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>
To: Gurjeet Singh <gurjeet(at)singh(dot)im>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, PGSQL Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Patch to send transaction commit/rollback stats to the stats collector unconditionally.
Date: 2014-03-19 22:20:52
Message-ID: 20140319222051.GP6899@eldon.alvh.no-ip.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Gurjeet Singh wrote:
> On Wed, Mar 19, 2014 at 4:22 PM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>
> > Gurjeet Singh <gurjeet(at)singh(dot)im> writes:
> > > Please find attached the patch to send transaction commit/rollback stats
> > to
> > > stats collector unconditionally.
> >
> > That's intentional to reduce stats traffic. What kind of performance
> > penalty does this patch impose? If the number of such transactions is
> > large enough to create a noticeable jump in the counters, I would think
> > that this would be a pretty darn expensive "fix".

> Presumably, on heavily used systems these transactions would form a small
> fraction. On relatively idle systems these transactions may be a larger
> fraction but that wouldn't affect the users since the database is not under
> stress anyway.

I'm not sure I understand the point of this whole thing. Realistically,
how many transactions are there that do not access any database tables?
If an application doesn't want to access stored data, why would it
connect to the database in the first place?

(I imagine you could use it to generate random numbers and such ...)

--
Álvaro Herrera http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Vik Fearing 2014-03-19 22:31:52 Re: four minor proposals for 9.5
Previous Message Alvaro Herrera 2014-03-19 22:17:52 Re: First-draft release notes for next week's releases