Re: relcache reference leak on refresh materialized view concurrently

From: yamamoto(at)valinux(dot)co(dot)jp (YAMAMOTO Takashi)
To: tgl(at)sss(dot)pgh(dot)pa(dot)us
Cc: pgsql-bugs(at)postgresql(dot)org, kgrittn(at)postgresql(dot)org
Subject: Re: relcache reference leak on refresh materialized view concurrently
Date: 2014-03-18 01:30:42
Message-ID: 20140318013042.BB80F71F23@kuma.localdomain
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-bugs

> yamamoto(at)valinux(dot)co(dot)jp (YAMAMOTO Takashi) writes:
>> the following patch fixes missing index_close in case
>> the mv has non-unique indexes.
>
> Hm ... I see the leak, I think, but isn't this an extraordinarily
> complex patch? Looks like adding

i tend to think it's simpler, but it's a matter of taste.

>
> else
> {
> index_close(indexRel, NoLock);
> }
>
> at the bottom of the "if" would also fix the problem, and would be
> far easier to verify.

yes, it's probably the physically smallest patch.

YAMAMOTO Takashi

>
> regards, tom lane

In response to

Browse pgsql-bugs by date

  From Date Subject
Next Message vwu98034 2014-03-18 03:18:40 BUG #9611: Current jdbc driver doesn't support any classes in Java 8 java.time
Previous Message Tom Lane 2014-03-18 01:21:19 Re: BUG #9606: pg_class relhaspkey column not updated on removal of primary key