| From: | Bruce Momjian <bruce(at)momjian(dot)us> |
|---|---|
| To: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
| Cc: | Robert Haas <robertmhaas(at)gmail(dot)com>, Peter Eisentraut <peter_e(at)gmx(dot)net>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: pg_ctl status with nonexistent data directory |
| Date: | 2014-03-07 14:29:30 |
| Message-ID: | 20140307142930.GA21154@momjian.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Fri, Mar 7, 2014 at 07:18:04PM +0530, Amit Kapila wrote:
> > OK, done with the attached patch Three is returned for status, but one
> > for other cases.
>
> I think it would have been better if it return status as 4 for cases where
> directory/file is not accessible (current new cases added by this patch).
>
> I think status 3 should be only return only when the data directory is valid
> and pid file is missing, because in script after getting this code, the next
> thing they will probably do is to start the server which doesn't seem a
> good fit for newly added cases.
OK, I have updated the attached patch to reflect this, and added a C
comment.
--
Bruce Momjian <bruce(at)momjian(dot)us> http://momjian.us
EnterpriseDB http://enterprisedb.com
+ Everyone has their own god. +
| Attachment | Content-Type | Size |
|---|---|---|
| pg_ctl.diff | text/x-diff | 5.9 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Heikki Linnakangas | 2014-03-07 14:31:11 | Re: atexit_callback can be a net negative |
| Previous Message | Florian Weimer | 2014-03-07 14:23:37 | Re: atexit_callback can be a net negative |