| From: | Bruce Momjian <bruce(at)momjian(dot)us> |
|---|---|
| To: | Andres Freund <andres(at)2ndquadrant(dot)com> |
| Cc: | Heikki Linnakangas <hlinnakangas(at)vmware(dot)com>, pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: missing RelationCloseSmgr in FreeFakeRelcacheEntry? |
| Date: | 2014-03-06 00:18:54 |
| Message-ID: | 20140306001854.GD20275@momjian.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, Nov 5, 2013 at 08:36:32PM +0100, Andres Freund wrote:
> On 2013-11-04 13:48:32 +0100, Andres Freund wrote:
> > What about just unowning the smgr entry with
> > if (rel->rd_smgr != NULL)
> > smgrsetowner(NULL, rel->rd_smgr)
> > when closing the fake relcache entry?
> >
> > That shouldn't require any further changes than changing the comment in
> > smgrsetowner() that this isn't something expected to frequently happen.
>
> Attached is a patch doing it like that, it required slightmy more
> invasive changes than that. With the patch applied we survive replay of
> a primary's make check run under valgrind without warnings.
Where are we on this patch?
--
Bruce Momjian <bruce(at)momjian(dot)us> http://momjian.us
EnterpriseDB http://enterprisedb.com
+ Everyone has their own god. +
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Fabrízio de Royes Mello | 2014-03-06 00:42:20 | Re: GSoC proposal - "make an unlogged table logged" |
| Previous Message | Tom Lane | 2014-03-06 00:12:15 | Re: Unportable coding in reorderbuffer.h |