Re: narwhal and PGDLLIMPORT

On 2014-02-02 02:15:39 +0100, Andres Freund wrote:
> On 2014-02-01 20:03:58 -0500, Tom Lane wrote:
> > I think we should give serious consideration to desupporting this
> > combination so that we can get rid of the plague of PGDLLIMPORT
> > marks. Obviously this would depend on confirming that there are
> > no more-interesting Windows build methods that require it --- but
> > if there are any, I'd sure demand that there be an active buildfarm
> > instance to keep us from breaking the case again in future.
>
> Weren't there more recent cases of needing to add PGDLLIMPORTs? I
> certainly remember pushing code to Craig's jenkins instance which made
> me do so for recent msvc
> builds... E.g. 7d7eee8bb702d7796a0d7c5886c1f4685f2e2806 and
> 708c529c7fdeba9387825d746752fc6f439d781e just a few days ago seems to be
> some of those cases.

And indeed, currawong failed with a link time error:
http://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=currawong&dt=2014-01-17%2013%3A30%3A21

I don't know why it didn't fail for postgres_fdw. Hm, maybe it's because
Mkvcbuild.pm links postgres_fdw with libpq, but not test_shm_mq?

Greetings,

Andres Freund

--
Andres Freund http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services