| From: | Stephen Frost <sfrost(at)snowman(dot)net> |
|---|---|
| To: | Kouhei Kaigai <kaigai(at)ak(dot)jp(dot)nec(dot)com> |
| Cc: | Kohei KaiGai <kaigai(at)kaigai(dot)gr(dot)jp>, Shigeru Hanada <shigeru(dot)hanada(at)gmail(dot)com>, Jim Mlodgenski <jimmy76(at)gmail(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, PgHacker <pgsql-hackers(at)postgresql(dot)org>, Peter Eisentraut <peter_e(at)gmx(dot)net> |
| Subject: | Re: Custom Scan APIs (Re: Custom Plan node) |
| Date: | 2014-01-27 14:39:34 |
| Message-ID: | 20140127143934.GD31026@tamriel.snowman.net |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
KaiGai Kohei,
* Kouhei Kaigai (kaigai(at)ak(dot)jp(dot)nec(dot)com) wrote:
> Is somebody available to volunteer to review the custom-scan patch?
I looked through it a bit and my first take away from it was that the
patches to actually use the new hooks were also making more changes to
the backend code, leaving me with the impression that the proposed
interface isn't terribly stable. Perhaps those changes should have just
been in the first patch, but they weren't and that certainly gave me
pause.
I'm also not entirely convinced that this is the direction to go in when
it comes to pushing down joins to FDWs. While that's certainly a goal
that I think we all share, this seems to be intending to add a
completely different feature which happens to be able to be used for
that. For FDWs, wouldn't we only present the FDW with the paths where
the foreign tables for that FDW, or perhaps just a given foreign server,
are being joined?
Thanks,
Stephen
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Robert Haas | 2014-01-27 14:43:04 | Re: shouldn't we log permission errors when accessing the configured trigger file? |
| Previous Message | Heikki Linnakangas | 2014-01-27 14:39:19 | Re: Race condition in b-tree page deletion |