Re: ALTER TABLESPACE ... MOVE ALL TO ...

From: Stephen Frost <sfrost(at)snowman(dot)net>
To: Simon Riggs <simon(at)2ndQuadrant(dot)com>
Cc: PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: ALTER TABLESPACE ... MOVE ALL TO ...
Date: 2014-01-20 16:02:53
Message-ID: 20140120160253.GL31026@tamriel.snowman.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

* Simon Riggs (simon(at)2ndQuadrant(dot)com) wrote:
> > ALTER TABLESPACE name MOVE OWNED TO name opt_nowait
>
> The ALL seems to have value. "MOVE ALL OWNED TO" sounds better.

I could go either way on this, really.

> > ALTER TABLESPACE name MOVE TABLES OWNED TO name opt_nowait
> > ALTER TABLESPACE name MOVE INDEXES OWNED TO name opt_nowait
>
> On those two, I think the docs need to be clearer that we mean that
> TABLES means tables, and yes we leave the indexes behind. Or that
> INDEXES means "and we leave the tables behind. This is intended to
> more easily separate tables and indexes into their own tablespaces."
> or similar.

Sure, I can certainly improve the documentation on that.

> I'm not clamouring for squeezing additional goodies from you, just to
> make a small change to avoid later confusion (for ALL users ;-) )

:) What are your thoughts on what I just proposed to Tom?

> Good feature, thanks for working on it.

Thanks!

Stephen

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Antonin Houska 2014-01-20 16:10:15 Re: Backup throttling
Previous Message Stephen Frost 2014-01-20 16:00:22 Re: ALTER TABLESPACE ... MOVE ALL TO ...