| From: | Andres Freund <andres(at)2ndquadrant(dot)com> |
|---|---|
| To: | Kevin Grittner <kgrittn(at)ymail(dot)com> |
| Cc: | Bruce Momjian <bruce(at)momjian(dot)us>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: clang's -Wmissing-variable-declarations shows some shoddy programming |
| Date: | 2013-12-19 23:09:38 |
| Message-ID: | 20131219230938.GD11483@alap2.anarazel.de |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 2013-12-19 14:56:38 -0800, Kevin Grittner wrote:
> Bruce Momjian <bruce(at)momjian(dot)us> wrote:
>
> > I have fixed the binary_upgrade_* variables defines, and Heikki has
> > fixed some other cases. Can you rerun the test against git head and
> > post the updated output? Thanks.
>
> I'm now seeing the attached.
Heh, too fast for me. I was just working on a patch to fix some of these
;)
The attached patch fixes some of the easiest cases, where either an
include was missing o a variable should have been static.
Greetings,
Andres Freund
--
Andres Freund http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services
| Attachment | Content-Type | Size |
|---|---|---|
| 0001-Mark-some-more-variables-as-static-or-include-the-ap.patch | text/x-patch | 4.2 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Sergey Konoplev | 2013-12-19 23:13:25 | Re: Hot standby 9.2.6 -> 9.2.6 PANIC: WAL contains references to invalid pages |
| Previous Message | Andres Freund | 2013-12-19 23:04:07 | Re: Hot standby 9.2.6 -> 9.2.6 PANIC: WAL contains references to invalid pages |