Re: clang's -Wmissing-variable-declarations shows some shoddy programming

From: Andres Freund <andres(at)2ndquadrant(dot)com>
To: Bruce Momjian <bruce(at)momjian(dot)us>
Cc: pgsql-hackers(at)postgresql(dot)org
Subject: Re: clang's -Wmissing-variable-declarations shows some shoddy programming
Date: 2013-12-19 10:38:42
Message-ID: 20131219103842.GA1759@alap2.anarazel.de
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi,

On 2013-12-18 22:11:03 -0500, Bruce Momjian wrote:
> Now that pg_upgrade has stabilized, I think it is time to centralize all
> the pg_upgrade_support control variables in a single C include file that
> can be used by the backend and by pg_upgrade_support. This will
> eliminate the compiler warnings too.

Btw, I think it's more or less lucky the current state works at all -
there's missing PGDLLIMPORT statements on the builtin side...

Greetings,

Andres Freund

--
Andres Freund http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Andres Freund 2013-12-19 10:44:20 Re: preserving forensic information when we freeze
Previous Message Fujii Masao 2013-12-19 10:26:47 Re: pgsql: Allow time delayed standbys and recovery