| From: | Andres Freund <andres(at)2ndquadrant(dot)com> |
|---|---|
| To: | David Rowley <dgrowleyml(at)gmail(dot)com> |
| Cc: | Robert Haas <robertmhaas(at)gmail(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: logical changeset generation v6.8 |
| Date: | 2013-12-13 11:12:30 |
| Message-ID: | 20131213111230.GG29402@awork2.anarazel.de |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 2013-12-13 20:58:24 +1300, David Rowley wrote:
> On Wed, Dec 11, 2013 at 1:11 PM, Robert Haas <robertmhaas(at)gmail(dot)com> wrote:
> This introduced a new compiler warning on the visual studios build:
> d:\postgres\b\src\backend\utils\cache\relcache.c(3958): warning C4715:
> 'RelationGetIndexAttrBitmap' : not all control paths return a value
> [D:\Postgres\b\postgres.vcxproj]
>
> The attached patch fixes it.
I thought we'd managed to get elog(ERROR) properly annotated as noreturn
on msvc as well?
Greetings,
Andres Freund
--
Andres Freund http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Heikki Linnakangas | 2013-12-13 11:47:24 | Bug in visibility map WAL-logging |
| Previous Message | Etsuro Fujita | 2013-12-13 09:53:02 | Minor comment improvement |