Re: Re: [BUGS] BUG #7873: pg_restore --clean tries to drop tables that don't exist

From: Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>
To: Dean Rasheed <dean(dot)a(dot)rasheed(at)gmail(dot)com>
Cc: Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>, Peter Eisentraut <peter_e(at)gmx(dot)net>
Subject: Re: Re: [BUGS] BUG #7873: pg_restore --clean tries to drop tables that don't exist
Date: 2013-12-02 20:28:01
Message-ID: 20131202202801.GD5731@eldon.alvh.no-ip.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-bugs pgsql-hackers

Dean Rasheed escribió:

> I think that memory gets freed at the end of the DROP command, so I
> don't think this is a concern. In any case, that RangeVar is only of
> order 50 bytes. If we were concerned about memory leakage here, a
> bigger concern would be the calling code in does_not_exist_skipping(),
> which is using NameListToString() which allocates at least 1024 bytes
> for the name of the non-existent object without freeing it.

Fair enough.

--
Álvaro Herrera http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services

In response to

Browse pgsql-bugs by date

  From Date Subject
Next Message Peter Eisentraut 2013-12-02 21:52:12 Re: Fwd: Re: [BUGS] BUG #7873: pg_restore --clean tries to drop tables that don't exist
Previous Message Dean Rasheed 2013-12-02 20:15:11 Re: Re: [BUGS] BUG #7873: pg_restore --clean tries to drop tables that don't exist

Browse pgsql-hackers by date

  From Date Subject
Next Message Andrew Dunstan 2013-12-02 20:29:50 Re: Trust intermediate CA for client certificates
Previous Message Stephen Frost 2013-12-02 20:22:53 Re: Extension Templates S03E11