From: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> |
---|---|
To: | Andres Freund <andres(at)2ndquadrant(dot)com> |
Cc: | J Smith <dark(dot)panda+lists(at)gmail(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: Errors on missing pg_subtrans/ files with 9.3 |
Date: | 2013-11-25 21:06:30 |
Message-ID: | 20131125210630.GG6597@eldon.alvh.no-ip.org |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Andres Freund escribió:
> On 2013-11-25 17:10:39 -0300, Alvaro Herrera wrote:
> > Let me point out that this is exactly the same code that would be
> > affected by my proposed fix for #8434, which would have this check the
> > updateXid in all cases, not only in KEYS_UPDATED as currently.
>
> Hm. I don't see a patch in any of the mails about #8434 although I seem
> to remember talking with you about one. Maybe that was on IM?
Ah, yeah, that's possible. The patch I proposed back then is attached
here. I haven't merged this to latest master; this applies cleanly on
top of 16a906f5350
> > I don't understand your comment about "can't check for committed". I
> > mean, if the updating transaction committed, then we need to return
> > failure to caller, HeapTupleUpdated.
>
> I mean that in the !KEYS_UPDATED case we don't need to abort if we're
> only acquiring a key share...
Hm, I think that's correct -- we don't need to abort. But we still need
to wait until the updater completes. So this proposed patch is not the
full story.
--
Álvaro Herrera http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services
Attachment | Content-Type | Size |
---|---|---|
patch-for-8434.patch | text/x-diff | 10.0 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Andreas Karlsson | 2013-11-25 21:07:58 | Put json type into alphabetical order in manual table |
Previous Message | Andrew Dunstan | 2013-11-25 21:01:39 | Re: why semicolon after begin is not allowed in postgresql? |