Re: BUG #8611: ECPG: unclosed comment "/*"

From: Michael Meskes <meskes(at)postgresql(dot)org>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Michael Meskes <meskes(at)postgresql(dot)org>, alexsav23(at)gmail(dot)com, pgsql-bugs(at)postgresql(dot)org
Subject: Re: BUG #8611: ECPG: unclosed comment "/*"
Date: 2013-11-24 11:30:10
Message-ID: 20131124113010.GC28081@feivel.credativ.lan
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-bugs

On Fri, Nov 22, 2013 at 03:19:10PM -0500, Tom Lane wrote:
> I don't see any way to "fix" it --- the best you can do is have a
> different set of users complaining, because C and SQL aren't consistent
> about this, and it's not obvious which convention should be followed
> where.

Well, I think we can in ecpg as ecpg knows whether it's parsing C code or SQL
code.

Alexei, could you please try the attached patch? IT's already in HEAD but I'd
prefer to have you run your sources through the changed ecpg before backporting
the patch.

Michael
--
Michael Meskes
Michael at Fam-Meskes dot De, Michael at Meskes dot (De|Com|Net|Org)
Michael at BorussiaFan dot De, Meskes at (Debian|Postgresql) dot Org
Jabber: michael.meskes at gmail dot com
VfL Borussia! Força Barça! Go SF 49ers! Use Debian GNU/Linux, PostgreSQL

Attachment Content-Type Size
ecpg.comment.diff text/x-diff 2.6 KB

In response to

Responses

Browse pgsql-bugs by date

  From Date Subject
Next Message Michael Meskes 2013-11-24 11:55:17 Re: BUG #8608: ECPG: sizeof() in EXEC SQL DECLARE SECTION
Previous Message dimitriraabe 2013-11-24 10:54:37 BUG #8622: Error when installing PostGIS via Stack Builder