| From: | Bruce Momjian <bruce(at)momjian(dot)us> |
|---|---|
| To: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Robert Haas <robertmhaas(at)gmail(dot)com>, Andres Freund <andres(at)2ndquadrant(dot)com>, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, Morten Hustveit <morten(at)eventures(dot)vc>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Suggestion: Issue warning when calling SET TRANSACTION outside transaction block |
| Date: | 2013-11-22 18:19:55 |
| Message-ID: | 20131122181955.GB32176@momjian.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Fri, Nov 22, 2013 at 12:17:41PM -0500, Bruce Momjian wrote:
> Good points. I have modified the attached patch to do as you suggested.
Also, I have read through the thread and summarized the positions of the
posters:
9.3 WARNING ERROR
SET none Tom, DavidJ, AndresF Robert, Kevin
SAVEPOINT error Tom, DavidJ, Robert, AndresF, Kevin
LOCK, DECLARE error Tom, DavidJ, Robert, AndresF, Kevin
Everyone seems to agree that SAVEPOINT, LOCK, and DECLARE should remain
as errors. Everyone also seems to agree that BEGIN and COMMIT should
remain warnings, and ABORT should be changed from notice to warning.
Our only disagreement seems to be how to handle the SET commands, which
used to report nothing. Would anyone else like to correct or express an
opinion? Given the current vote count and backward-compatibility,
warning seems to be the direction we are heading.
--
Bruce Momjian <bruce(at)momjian(dot)us> http://momjian.us
EnterpriseDB http://enterprisedb.com
+ Everyone has their own god. +
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Bruce Momjian | 2013-11-22 18:32:30 | Re: pg_upgrade ?deficiency |
| Previous Message | Andrew Gierth | 2013-11-22 18:05:30 | Re: UNNEST with multiple args, and TABLE with multiple funcs |