| From: | Andres Freund <andres(at)2ndquadrant(dot)com> |
|---|---|
| To: | Bruce Momjian <bruce(at)momjian(dot)us> |
| Cc: | Robert Haas <robertmhaas(at)gmail(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, Morten Hustveit <morten(at)eventures(dot)vc>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Suggestion: Issue warning when calling SET TRANSACTION outside transaction block |
| Date: | 2013-11-19 18:08:05 |
| Message-ID: | 20131119180805.GB22498@alap2.anarazel.de |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 2013-11-19 13:05:01 -0500, Bruce Momjian wrote:
> SAVEPOINT
> test=> ROLLBACK TO SAVEPOINT asdf;
> ERROR: ROLLBACK TO SAVEPOINT can only be used in transaction blocks
>
> Notice that they do _not_ check their arguments; they just throw
> errors. With this patch they issue warnings and evaluate their
> arguments:
> test=> ROLLBACK TO SAVEPOINT asdf;
> WARNING: ROLLBACK TO SAVEPOINT can only be used in transaction blocks
> ROLLBACK
>
> However, SAVEPOINT/ROLLBACK throw weird errors when they are evaluated
> outside a multi-statement transaction, so their arguments are not
> evaluated. This might be why they were originally marked as errors.
Why change the historical behaviour for savepoints?
Greetings,
Andres Freund
--
Andres Freund http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Robert Haas | 2013-11-19 18:09:15 | Re: additional json functionality |
| Previous Message | Bruce Momjian | 2013-11-19 18:07:39 | Re: Re: Suggestion: Issue warning when calling SET TRANSACTION outside transaction block |