From: | Andres Freund <andres(at)2ndquadrant(dot)com> |
---|---|
To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
Cc: | pgsql-hackers(at)postgresql(dot)org |
Subject: | Re: Add %z support to elog/ereport? |
Date: | 2013-11-11 17:37:53 |
Message-ID: | 20131111173753.GH2401@awork2.anarazel.de |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On 2013-11-11 12:18:46 -0500, Tom Lane wrote:
> Andres Freund <andres(at)2ndquadrant(dot)com> writes:
> > gettext has support for it afaics, it's part of POSIX:
>
> Really? [ pokes around at pubs.opengroup.org ] Hm, I don't see it
> in Single Unix Spec v2 (1997), but it is there in POSIX issue 7 (2008).
> Also, the POSIX page says it defers to the C standard, and I see it
> in C99. Too bad not all our platforms are C99 yet :-(
Seems to be 2001:
http://pubs.opengroup.org/onlinepubs/007904975/functions/fprintf.html
Even though the date says it's from 2004, it's IEEE Std 1003.1 + minor
errata.
> Actually this raises an interesting testing question: how sure are we
> that there aren't already some format strings in the code that depend
> on C99 additions to the printf spec? If they're not in code paths
> exercised by the regression tests, I'm not sure we'd find out from
> the buildfarm.
I agree, it's problematic. Especially as such code is likely to be in
error paths. I seem to recall you fixing some occurances you found
manually some time back so we clearly don't have an automated process
for it yet.
Greetings,
Andres Freund
--
Andres Freund http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services
From | Date | Subject | |
---|---|---|---|
Next Message | Andres Freund | 2013-11-11 17:40:55 | Re: Add %z support to elog/ereport? |
Previous Message | Robert Haas | 2013-11-11 17:31:55 | Re: Add %z support to elog/ereport? |