Re: Record comparison compiler warning

From: Bruce Momjian <bruce(at)momjian(dot)us>
To: Kevin Grittner <kgrittn(at)ymail(dot)com>
Cc: PostgreSQL-development <pgsql-hackers(at)postgreSQL(dot)org>
Subject: Re: Record comparison compiler warning
Date: 2013-10-16 19:51:23
Message-ID: 20131016195123.GE18048@momjian.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Wed, Oct 16, 2013 at 11:49:13AM -0700, Kevin Grittner wrote:
> Bruce Momjian <bruce(at)momjian(dot)us> wrote:
>
> > I am seeing this compiler warning in git head:
> >
> >     rowtypes.c: In function 'record_image_cmp':
> >     rowtypes.c:1433: warning: 'cmpresult' may be used
> >     uninitialized in this function rowtypes.c:1433: note: 'cmpresult' was declared here
>
> I had not gotten a warning under either gcc or clang, but that was
> probably because I was doing assert-enabled builds, and the
> Assert(false) saved me.  That seemed a little marginal anyway, so
> how about this?:

Would you please send the file as ASCII, e.g. not:

<A0><A0><A0><A0><A0><A0><A0><A0><A0><A0><A0><A0><A0><A0><A0><A0><A0><A0><A0> default:

--
Bruce Momjian <bruce(at)momjian(dot)us> http://momjian.us
EnterpriseDB http://enterprisedb.com

+ Everyone has their own god. +

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Andres Freund 2013-10-16 20:04:29 Re: removing old ports and architectures
Previous Message Bruce Momjian 2013-10-16 19:49:54 Re: removing old ports and architectures