C question about bitmasks in datetime.c

From: Bruce Momjian <bruce(at)momjian(dot)us>
To: PostgreSQL-development <pgsql-hackers(at)postgreSQL(dot)org>
Subject: C question about bitmasks in datetime.c
Date: 2013-10-01 15:15:36
Message-ID: 20131001151536.GC13385@momjian.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

I see a few cases of this code in src/backend/utils/adt/datetime.c:

else if ((fmask & DTK_DATE_M) != DTK_DATE_M)

Wouldn't this be clearer as:

else if (fmask & DTK_DATE_M)

--
Bruce Momjian <bruce(at)momjian(dot)us> http://momjian.us
EnterpriseDB http://enterprisedb.com

+ It's impossible for everything to be true. +

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Andres Freund 2013-10-01 15:17:35 Re: C question about bitmasks in datetime.c
Previous Message Robert Haas 2013-10-01 14:58:10 Re: logical changeset generation v6.1