Re: pg_stat_statements: calls under-estimation propagation

From: Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>
To: Daniel Farina <daniel(at)fdr(dot)io>
Cc: samthakur74 <samthakur74(at)gmail(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: pg_stat_statements: calls under-estimation propagation
Date: 2013-09-23 14:19:43
Message-ID: 20130923141943.GF4832@eldon.alvh.no-ip.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Daniel Farina escribió:
> On Fri, Sep 20, 2013 at 1:11 AM, Daniel Farina <daniel(at)fdr(dot)io> wrote:
> > I think the n-call underestimation propagation may not be quite precise for
> > various detailed reasons (having to do with 'sticky' queries) and to make it
> > precise is probably more work than it's worth. And, on more reflection, I'm
> > also having a hard time imaging people intuiting that value usefully. So,
> > here's a version removing that.
>
> I forgot about removal of the relevant SGML, amended here in v6.

Nice.

You need to remove the --1.1.sql entry (the file itself and the DATA
entry in Makefile).

Also, I think it would be good to have a common "fooRandom()" routine,
instead of having a second copy of PostmasterRandom. Might I suggest
putting it in a new file under src/common/.

--
Álvaro Herrera http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Marti Raudsepp 2013-09-23 15:23:49 Re: PostgreSQL 9.3 beta breaks some extensions "make install"
Previous Message Alvaro Herrera 2013-09-23 13:36:06 Re: [RFC] Extend namespace of valid guc names