Re: lcr v5 - introduction of InvalidCommandId

From: Andres Freund <andres(at)2ndquadrant(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Robert Haas <robertmhaas(at)gmail(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: lcr v5 - introduction of InvalidCommandId
Date: 2013-09-09 22:46:50
Message-ID: 20130909224650.GI841236@alap2.anarazel.de
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 2013-09-09 18:43:51 -0400, Tom Lane wrote:
> Robert Haas <robertmhaas(at)gmail(dot)com> writes:
> > On Thu, Sep 5, 2013 at 3:23 PM, Andres Freund <andres(at)2ndquadrant(dot)com> wrote:
> >> So, a very slightly updated patch attached.
>
> > Committed.
>
> Hmm ... shouldn't this patch adjust the error messages in
> CommandCounterIncrement? We just took away one possible command.
> It's pretty nitpicky, especially since many utility commands do
> more than one CommandCounterIncrement, but still ...

Hm. You're talking about "cannot have more than 2^32-2 commands in a
transaction"? If so, the patch and the commit seem to have adjusted that?

Greetings,

Andres Freund

--
Andres Freund http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2013-09-09 22:53:36 Re: lcr v5 - introduction of InvalidCommandId
Previous Message Tom Lane 2013-09-09 22:43:51 Re: lcr v5 - introduction of InvalidCommandId