Re: [9.4] Make full_page_writes only settable on server start?

From: Andres Freund <andres(at)2ndquadrant(dot)com>
To: Jeff Davis <pgsql(at)j-davis(dot)com>
Cc: Robert Haas <robertmhaas(at)gmail(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [9.4] Make full_page_writes only settable on server start?
Date: 2013-09-04 15:00:55
Message-ID: 20130904150055.GC11189@awork2.anarazel.de
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 2013-09-04 07:57:15 -0700, Jeff Davis wrote:
> XLogSaveBufferForHint() calls XLogCheckBuffer() but doesn't also look at
> the full page writes setting (like in XLogInsert()). That means, if
> checksums are enabled and full_page_writes is off, we'll still write
> some full page images for checksums. I'd like to remedy that.

I don't think that's really as easy as it sounds without removing the
ability to do base backups with full_page_writes = off. The interlocking
that would require makes things complex...
Personally I'd rather forbid enabling checkpoints in the combination
with full_page_writes = off. That doesn't seem like a good idea to me
and I am far from convinced it's actually going to work in all corner cases.

Greetings,

Andres Freund

--
Andres Freund http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Stephen Frost 2013-09-04 15:01:19 Re: [v9.4] row level security
Previous Message Jeff Davis 2013-09-04 14:57:15 Re: [9.4] Make full_page_writes only settable on server start?