From: | Andres Freund <andres(at)2ndquadrant(dot)com> |
---|---|
To: | Robert Haas <robertmhaas(at)gmail(dot)com> |
Cc: | "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: dynamic background workers, round two |
Date: | 2013-08-28 18:44:05 |
Message-ID: | 20130828184405.GB32052@awork2.anarazel.de |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On 2013-08-28 14:04:59 -0400, Robert Haas wrote:
> >> + <function>RegisterDynamicBackgroundWorker(<type>BackgroundWorker
> >> + *worker, BackgroundWorkerHandle **handle</type>)</function>. Unlike
> >> + <function>RegisterBackgroundWorker</>, which can only be called from within
> >> + the postmaster, <function>RegisterDynamicBackgroundWorker</function> must be
> >> + called from a regular backend.
> >> </para>
> >
> > s/which can only be called from within the posmaster/during initial
> > startup, via shared_preload_libraries/?
>
> This seems like a possible doc clarification not intimately related to
> the patch at hand. The only reason that paragraph is getting reflowed
> is because of the additional argument to
> RegisterDynamicBackgroundWorker(). On the substance, I could go
> either way on whether your proposed text is better than what's there
> now.
I agree it's unrelated. I just noticed because it was in the diff ;)
> It seems like it might need a bit of wordsmithing, anyway.
Yes, looks like it could use some. It's not going to be me doing it
tho...
Greetings,
Andres Freund
--
Andres Freund http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services
From | Date | Subject | |
---|---|---|---|
Next Message | Josh Berkus | 2013-08-28 18:44:22 | Re: What happens at BIND time? |
Previous Message | Tom Lane | 2013-08-28 18:37:12 | Re: ALTER SYSTEM SET command to change postgresql.conf parameters (RE: Proposal for Allow postgresql.conf values to be changed via SQL [review]) |