| From: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> |
|---|---|
| To: | Michael Cronenworth <mike(at)cchtml(dot)com> |
| Cc: | pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: Fix Windows socket error checking for MinGW |
| Date: | 2013-08-19 14:49:33 |
| Message-ID: | 20130819144933.GC9264@eldon.alvh.no-ip.org |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Michael Cronenworth wrote:
> On 08/17/2013 12:16 AM, Noah Misch wrote:
> > 1. Redefine those constants for more (all?) compilers.
> > 2. Remove that block and put #ifdef around all usage of such constants in
> > frontend code, as you have done.
> > 3. Remove that block and make src/backend/port/win32/socket.c frontend-usable,
> > so frontend code can treat errno like backend code treats errno.
> >
> > What do you recommend?
>
> Option 1 is dangerous.
How so?
--
Álvaro Herrera http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Kevin Grittner | 2013-08-19 14:51:32 | Re: Should we remove "not fast" promotion at all? |
| Previous Message | Robert Haas | 2013-08-19 14:35:14 | Re: Fix Windows socket error checking for MinGW |