Re: Disabling ALTER SYSTEM SET WAS: Re: ALTER SYSTEM SET command to change postgresql.conf parameters

From: Stephen Frost <sfrost(at)snowman(dot)net>
To: Bruce Momjian <bruce(at)momjian(dot)us>
Cc: Josh Berkus <josh(at)agliodbs(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Andres Freund <andres(at)2ndquadrant(dot)com>, Greg Stark <stark(at)mit(dot)edu>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Fujii Masao <masao(dot)fujii(at)gmail(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, Amit Kapila <amit(dot)kapila(at)huawei(dot)com>, Dimitri Fontaine <dimitri(at)2ndquadrant(dot)fr>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: Disabling ALTER SYSTEM SET WAS: Re: ALTER SYSTEM SET command to change postgresql.conf parameters
Date: 2013-08-05 18:52:40
Message-ID: 20130805185240.GR2706@tamriel.snowman.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

* Bruce Momjian (bruce(at)momjian(dot)us) wrote:
> On Mon, Aug 5, 2013 at 11:16:24AM -0700, Josh Berkus wrote:
> > I don't think this is a small thing. I really think we'll get a LOT of
> > blowback from sysadmins -- and maybe even refusals to upgrade -- if we
> ----------------------------------
>
> Really? Is that a reasonable statement?

I don't believe Josh was saying that in jest.. I certainly believe that
it could happen.

> > As I've said before, I think the disable switch can be a follow-up patch
> > to the main ALTER SYSTEM SET patch.

Even if it's a different patch, it should go in at the same time, imv..

> You are mixing the behaviors of disabling the ALTER SYSTEM SET command
> with recognizing ALTER SYSTEM SET settings already made --- the later
> would be to fix a problem with the server not starting.

That's a good point.

> However,
> frankly, these are flat files, so I don't see a problem with having the
> administrator modify the flat file.

Admins on Ubuntu or Debian or a host of their derivatives aren't going
to be looking in $PGDATA for config files that they have to hand-modify
to fix something the DBA did. When they eventually figure it out,
they're going to be *very* unhappy.

> Would disabling the ALTER SYSTEM SET command also disable recognizing
> any ALTER SYSTEM SET commands already performed? Maybe that was already
> understood, but I missed that point.

I don't have an answer to that one, though I do like the idea of a
switch that says "only read the settings from my postgresql.conf file".

Thanks,

Stephen

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message David Gudeman 2013-08-05 18:55:51 Re: pass-through queries to foreign servers
Previous Message Stephen Frost 2013-08-05 18:44:28 Re: Unsafe GUCs and ALTER SYSTEM WAS: Re: ALTER SYSTEM SET