* Alvaro Herrera (alvherre(at)2ndquadrant(dot)com) wrote:
> pgsecure_open_client() returns -1 if it can't lock the mutex. This is a
> problem because the callers are not prepared for that return value. I
> think it should return PGRES_POLLING_FAILED instead, after setting an
> appropriate error message in conn->errorMessage.
Ah, right, adding it there was a bit of a late addition, tbh.
> initialize_SSL() fails to set an error message. The return code of -1
> seems fine here.
Right, will improve.
Thanks!
Stephen