Re: [COMMITTERS] pgsql: Allow background workers to be started dynamically.

From: Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>
To: Andres Freund <andres(at)2ndquadrant(dot)com>
Cc: Robert Haas <robertmhaas(at)gmail(dot)com>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: [COMMITTERS] pgsql: Allow background workers to be started dynamically.
Date: 2013-07-20 04:39:44
Message-ID: 20130720043944.GK4130@eldon.alvh.no-ip.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

Andres Freund escribió:

> On 2013-07-19 08:23:25 -0400, Robert Haas wrote:

> > And I'd also propose getting rid
> > of bgw_sighup and bgw_sigterm in both branches, while we're at it.
> > AFAICT, they don't add any functionality, and they're basically
> > unusable for dynamically started background workers. Probably better
> > not to get people to used to using them.
>
> I don't have a problem with getting rid of those, it's easy enough to
> register them inside the worker and it's safe since we start with
> blocked signals. I seem to remember some discussion about why they were
> added but I can't find a reference anymore. Alvaro, do you remember?

I left them there because it was easy; but they were absolutely
necessary only until we decided that we would start the worker's main
function with signals blocked. I don't think there's any serious reason
not to remove them now.

--
Álvaro Herrera http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Alvaro Herrera 2013-07-20 04:41:49 Re: pgsql: Fix regex match failures for backrefs combined with non-greedy q
Previous Message Alvaro Herrera 2013-07-20 04:36:28 Re: pgsql: Fix regex match failures for backrefs combined with non-greedy q

Browse pgsql-hackers by date

  From Date Subject
Next Message Amit kapila 2013-07-20 06:50:18 Re: Adding new joining alghoritm to postgresql
Previous Message Dimitri Fontaine 2013-07-20 00:12:16 Re: CREATE EVENT TRIGGER syntax