Re: Kudos for Reviewers -- straw poll

From: Bruce Momjian <bruce(at)momjian(dot)us>
To: Brendan Jurd <direvus(at)gmail(dot)com>
Cc: Josh Berkus <josh(at)agliodbs(dot)com>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: Kudos for Reviewers -- straw poll
Date: 2013-06-26 13:14:07
Message-ID: 20130626131407.GB3341@momjian.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Wed, Jun 26, 2013 at 10:40:17AM +1000, Brendan Jurd wrote:
> On 26 June 2013 03:17, Josh Berkus <josh(at)agliodbs(dot)com> wrote:
> > How should reviewers get credited in the release notes?
> >
> > a) not at all
> > b) in a single block titled "Reviewers for this version" at the bottom.
> > c) on the patch they reviewed, for each patch
>
> A weak preference for (c), with (b) running a close second. As others
> have suggested, a review that leads to significant commitable changes
> to the patch should bump the credit to co-authorship.

As a reminder, I tried a variant of C for 9.2 beta release notes, and
got lots of complaints, particularly because the line describing the
feature now had many more names on it.

In my opinion, adding reviewer names to each feature item might result
in the removal of all names from features.

A poll is nice for gauging interest, but many people who vote don't
understand the ramifications of what they are voting on.

--
Bruce Momjian <bruce(at)momjian(dot)us> http://momjian.us
EnterpriseDB http://enterprisedb.com

+ It's impossible for everything to be true. +

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Andrew Dunstan 2013-06-26 13:25:27 Re: Kudos for Reviewers -- straw poll
Previous Message Bruce Momjian 2013-06-26 12:52:17 Re: Hash partitioning.