From: | Andres Freund <andres(at)2ndquadrant(dot)com> |
---|---|
To: | Kevin Grittner <kgrittn(at)ymail(dot)com> |
Cc: | "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: changeset generation v5-01 - Patches & git tree |
Date: | 2013-06-21 01:32:35 |
Message-ID: | 20130621013235.GA32625@awork2.anarazel.de |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Hi Kevin!
On 2013-06-20 15:57:07 -0700, Kevin Grittner wrote:
> Andres Freund <andres(at)2ndquadrant(dot)com> wrote:
>
> >> 0007: Adjust Satisfies* interface: required, mechanical,
>
> > Version v5-01 attached
>
> I'm still working on a review and hope to post something more
> substantive by this weekend
Cool!
>, but when applying patches in numeric
> order, this one did not compile cleanly.
>
> gcc -O2 -Wall -Wmissing-prototypes -Wpointer-arith -Wdeclaration-after-statement -Wendif-labels -Wmissing-format-attribute -Wformat-security -fno-strict-aliasing -fwrapv -fexcess-precision=standard -g -I../../../../src/include -D_GNU_SOURCE -I/usr/include/libxml2 -c -o allpaths.o allpaths.c -MMD -MP -MF .deps/allpaths.Po
> vacuumlazy.c: In function ‘heap_page_is_all_visible’:
> vacuumlazy.c:1725:3: warning: passing argument 1 of ‘HeapTupleSatisfiesVacuum’ from incompatible pointer type [enabled by default]
> In file included from vacuumlazy.c:61:0:
> ../../../src/include/utils/tqual.h:84:20: note: expected ‘HeapTuple’ but argument is of type ‘HeapTupleHeader’
>
> Could you post a new version of that?
Hrmpf. There was one hunk in 0013 instead of 0007.
I made sure that every commit again applies and compiles cleanly. git
rebase -i --exec to the rescue.
Found two other issues:
* recptr not assigned in 0010
* unsafe use of non-volatile variable across longjmp() 0013
Pushed and attached.
Greetings,
Andres Freund
--
Andres Freund http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services
From | Date | Subject | |
---|---|---|---|
Next Message | Bruce Momjian | 2013-06-21 01:35:34 | Re: [PATCH] Exorcise "zero-dimensional" arrays (Was: Re: Should array_length() Return NULL) |
Previous Message | Josh Berkus | 2013-06-21 01:32:33 | Why can't I use windowing functions over ordered aggregates? |