Re: [PATCH] Remove useless USE_PGXS support in contrib

Le mercredi 19 juin 2013 22:22:22, Andrew Dunstan a écrit :
> On 06/19/2013 03:52 PM, Dimitri Fontaine wrote:
> > Peter Eisentraut <peter_e(at)gmx(dot)net> writes:
> >> We could do something like
> >>
> >> PG_CONFIG = fake_intree_pg_config
> >> PGXS := $(shell $(PG_CONFIG) --pgxs)
> >> include $(PGXS)
> >
> > There's something to that idea. Of course we would need to offer a
> > comment about the PG_CONFIG game and propose something else for real
> > world extensions (PG_CONFIG ?= pg_config).
> >
> >> where fake_intree_pg_config is a purpose-built shell script that points
> >> to the right places inside the source tree.
> >
> > If that works, that gets my preference over removing PGXS support in
> > contrib modules. Setting an example is important, in-tree build is not
> > a useful example for anyone but contributors to core.
>
> Not true - you're forgetting there is no pgxs for MSVC builds.

PGXS + MSVC is still in the TODO list.... I won't be able to work on that.

> If we're going to enable building of contrib modules using pgxs but
> without an install we will make targets for that, and buildfarm support.

With the set of patches I sent, contrib can be built with PGXS, there is no
issue here....Except maybe pg_xlogdump, and this one might be improved not to
have to rebuild shared object from postgresql (IIRC it is a static build or
something like that)...

--
Cédric Villemain +33 (0)6 20 30 22 52
http://2ndQuadrant.fr/
PostgreSQL: Support 24x7 - Développement, Expertise et Formation