Re: PostgreSQL 9.3 beta breaks some extensions "make install"

From: Cédric Villemain <cedric(at)2ndquadrant(dot)com>
To: pgsql-hackers(at)postgresql(dot)org
Cc: Christoph Berg <myon(at)debian(dot)org>, Peter Eisentraut <peter_e(at)gmx(dot)net>
Subject: Re: PostgreSQL 9.3 beta breaks some extensions "make install"
Date: 2013-06-02 10:56:25
Message-ID: 201306021256.30302.cedric@2ndquadrant.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Le mardi 28 mai 2013 14:10:14, Cédric Villemain a écrit :
> > I just took time to inspect our contribs, USE_PGXS is not supported by
> > all of them atm because of SHLIB_PREREQS (it used submake) I have a
> > patch pending here to fix that.
>
> Attached patch fix SHLIB_PREREQS when building with USE_PGXS
>
> commit 19e231b introduced SHLIB_PREREQS but failed to port that to PGXS
> build.
>
> The issue is that "submake-*" can not be built with PGXS, in this case they
> must check that expected files are present (and installed).
> Maybe it is better to only check if they have been built ?
>
> This fix the build of dblink and postgres_fdw (make USE_PGXS=1)

This patch is a bugfix and IMO should be applied in 9.1 and 9.2.
Else we should remove the PGXS support from the Makefile of the contribs dblink
and postgres_fdw because it is not working currently.
--
Cédric Villemain +33 (0)6 20 30 22 52
http://2ndQuadrant.fr/
PostgreSQL: Support 24x7 - Développement, Expertise et Formation

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Cédric Villemain 2013-06-02 13:53:31 Re: PostgreSQL 9.3 beta breaks some extensions "make install"
Previous Message Simon Riggs 2013-06-02 10:39:42 Re: Deferring transaction wraparound