Re: Running pgindent

From: Stephen Frost <sfrost(at)snowman(dot)net>
To: Bruce Momjian <bruce(at)momjian(dot)us>
Cc: Andrew Dunstan <andrew(at)dunslane(dot)net>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Magnus Hagander <magnus(at)hagander(dot)net>, Robert Haas <robertmhaas(at)gmail(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Running pgindent
Date: 2013-05-31 20:57:20
Message-ID: 20130531205720.GZ6434@tamriel.snowman.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

* Bruce Momjian (bruce(at)momjian(dot)us) wrote:
> On Fri, May 31, 2013 at 03:51:30PM -0400, Andrew Dunstan wrote:
> > I spent quite a lot of time trying to make the tool behave the same
> > as the old script.
>
> Yes, and I believe we tested running the Perl version to make sure it
> was the same, so the changes we are seeing are just normal (unfortunate)
> adjustments by pgindent.

Fair enough, thanks for the efforts and for looking into it, apologies
for my complaining.

If no one objects, I'm going to review the conditional statements and
similar lines which could be split out on to multiple lines instead of
being squeezed closer to the left edge and not lined up properly. Then
I'll try and get pgindent running locally. If I can get that happening
and it doesn't want to further change the modifications that I make,
then I'll commit those cleanups. This will only be for changes made
during this latest pgindent run and only against master- I don't want to
create any more code churn beyond what's already being impacted.

Thanks,

Stephen

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Bruce Momjian 2013-06-01 01:49:23 Re: Running pgindent
Previous Message Stephen Frost 2013-05-31 20:49:09 Re: removing PD_ALL_VISIBLE