| From: | Bruce Momjian <bruce(at)momjian(dot)us> |
|---|---|
| To: | Peter Eisentraut <peter_e(at)gmx(dot)net> |
| Cc: | pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: units in postgresql.conf comments |
| Date: | 2013-05-30 03:43:34 |
| Message-ID: | 20130530034334.GB4715@momjian.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, May 29, 2013 at 09:59:10PM -0400, Peter Eisentraut wrote:
> I think these sort of entries don't make much sense:
>
> #wal_sender_timeout = 60s # in milliseconds; 0 disables
>
> I think we should remove units from the comments when it's clear from
> the name or the default value that time units are accepted.
We are documenting what happens when there are no units. Are people are
going to change '60s' to '50' and assume that is '50s'? Hopefully not.
I do like the clutter avoidance of removing the units from the comments.
--
Bruce Momjian <bruce(at)momjian(dot)us> http://momjian.us
EnterpriseDB http://enterprisedb.com
+ It's impossible for everything to be true. +
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Jeff Davis | 2013-05-30 03:54:57 | Eliminating PD_ALL_VISIBLE, take 2 |
| Previous Message | Bruce Momjian | 2013-05-30 03:41:03 | Re: Running pgindent |